Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2e cleanup. #853

Merged
merged 6 commits into from
Sep 12, 2024
Merged

E2e cleanup. #853

merged 6 commits into from
Sep 12, 2024

Conversation

arhamchordia
Copy link
Collaborator

Changes are made to update e2e test suite to work in tandem with the latest release of interchaintest repo of v8.

Still a work in progress PR as code is all cleaned up but it needs to be tested.

ajansari95
ajansari95 previously approved these changes Sep 10, 2024
Copy link
Contributor

@ajansari95 ajansari95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ajansari95
Copy link
Contributor

the changes here lools good what else we need here as its draft?

@arhamchordia
Copy link
Collaborator Author

We need a hub deployment to pull images from.

@ajansari95
Copy link
Contributor

We need a hub deployment to pull images from.

i assume a docker image is needed?
can be pulled from here - https://github.com/cosmos/gaia/pkgs/container/gaia

@arhamchordia
Copy link
Collaborator Author

Yeah. From a cleanup perspective it is ready. But not from a working perspective.

@arhamchordia
Copy link
Collaborator Author

And if we just stick to cleanup then it is all set to merge.

@arhamchordia arhamchordia marked this pull request as ready for review September 11, 2024 08:40
@ajansari95 ajansari95 merged commit e293275 into main Sep 12, 2024
4 checks passed
@ajansari95 ajansari95 deleted the fix/e2e branch September 12, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants